Attention is currently required from: Daniel Peng, Karthik Ramasubramanian.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email )
Change subject: mb/google/dedede/var/galtic: Re-factor the Memory Setting
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79976/comment/1b4443fa_dcced3df :
PS2, Line 7: Re-factor the Memory Setting
The original memory `K4UBE3D4AA-MGCR` is used to spd-3.hex in mem_parts_used.txt, not for the spd-1. […]
yes, you should change the description.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79976?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Gerrit-Change-Number: 79976
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 07:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-MessageType: comment