HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36703 )
Change subject: fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment ......................................................................
fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment
Change-Id: I0f02a4508b78cdb0706df6f288138a9db54e229e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/fsp_rangeley/northbridge.c M src/soc/intel/fsp_baytrail/northcluster.c M src/soc/intel/fsp_broadwell_de/northcluster.c 3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/36703/1
diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c index 63f2068..0ab60fb 100644 --- a/src/northbridge/intel/fsp_rangeley/northbridge.c +++ b/src/northbridge/intel/fsp_rangeley/northbridge.c @@ -76,7 +76,7 @@
}
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource;
@@ -133,7 +133,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (bmbound_hi - 0x100000000) >> 20); }
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void mc_read_resources(struct device *dev) diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c index 797039a..50ec988 100644 --- a/src/soc/intel/fsp_baytrail/northcluster.c +++ b/src/soc/intel/fsp_baytrail/northcluster.c @@ -102,7 +102,7 @@
}
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource;
@@ -157,7 +157,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", highmem_size >> 20);
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void nc_read_resources(struct device *dev) diff --git a/src/soc/intel/fsp_broadwell_de/northcluster.c b/src/soc/intel/fsp_broadwell_de/northcluster.c index 2e27d37..35d01b6 100644 --- a/src/soc/intel/fsp_broadwell_de/northcluster.c +++ b/src/soc/intel/fsp_broadwell_de/northcluster.c @@ -30,7 +30,7 @@ static const int legacy_hole_base_k = 0xa0000 / 1024; static const int legacy_hole_size_k = 384;
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource; u32 pcie_config_base, pcie_config_size; @@ -117,7 +117,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", highmem_size >> 20);
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void nc_read_resources(struct device *dev)
Hello Patrick Rudolph, Huang Jin, Philipp Deppenwiese, David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36703
to look at the new patch set (#2).
Change subject: fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment ......................................................................
fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment
Change-Id: I0f02a4508b78cdb0706df6f288138a9db54e229e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/fsp_rangeley/northbridge.c M src/soc/intel/fsp_baytrail/northcluster.c M src/soc/intel/fsp_broadwell_de/northcluster.c 3 files changed, 6 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/36703/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36703 )
Change subject: fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36703 )
Change subject: fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment ......................................................................
fsp{rangeley,baytrail,broadwell_de}: Fix dead assignment
Change-Id: I0f02a4508b78cdb0706df6f288138a9db54e229e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36703 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/fsp_rangeley/northbridge.c M src/soc/intel/fsp_baytrail/northcluster.c M src/soc/intel/fsp_broadwell_de/northcluster.c 3 files changed, 6 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/fsp_rangeley/northbridge.c b/src/northbridge/intel/fsp_rangeley/northbridge.c index 63f2068..4ebbe7e 100644 --- a/src/northbridge/intel/fsp_rangeley/northbridge.c +++ b/src/northbridge/intel/fsp_rangeley/northbridge.c @@ -76,7 +76,7 @@
}
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource;
@@ -87,8 +87,6 @@ IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); - - return index; }
static void mc_add_dram_resources(struct device *dev) @@ -133,7 +131,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", (bmbound_hi - 0x100000000) >> 20); }
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void mc_read_resources(struct device *dev) diff --git a/src/soc/intel/fsp_baytrail/northcluster.c b/src/soc/intel/fsp_baytrail/northcluster.c index 797039a..474ba84 100644 --- a/src/soc/intel/fsp_baytrail/northcluster.c +++ b/src/soc/intel/fsp_baytrail/northcluster.c @@ -102,7 +102,7 @@
}
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource;
@@ -113,8 +113,6 @@ IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); - - return index; }
static void mc_add_dram_resources(struct device *dev) @@ -157,7 +155,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", highmem_size >> 20);
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void nc_read_resources(struct device *dev) diff --git a/src/soc/intel/fsp_broadwell_de/northcluster.c b/src/soc/intel/fsp_broadwell_de/northcluster.c index 2e27d37..a630c1b 100644 --- a/src/soc/intel/fsp_broadwell_de/northcluster.c +++ b/src/soc/intel/fsp_broadwell_de/northcluster.c @@ -30,7 +30,7 @@ static const int legacy_hole_base_k = 0xa0000 / 1024; static const int legacy_hole_size_k = 384;
-static int add_fixed_resources(struct device *dev, int index) +static void add_fixed_resources(struct device *dev, int index) { struct resource *resource; u32 pcie_config_base, pcie_config_size; @@ -52,8 +52,6 @@ IORESOURCE_FIXED | IORESOURCE_STORED | IORESOURCE_ASSIGNED;
mmio_resource(dev, index++, legacy_hole_base_k, legacy_hole_size_k); - - return index; }
static void mc_add_dram_resources(struct device *dev) @@ -117,7 +115,7 @@ printk(BIOS_INFO, "Available memory above 4GB: %lluM\n", highmem_size >> 20);
- index = add_fixed_resources(dev, index); + add_fixed_resources(dev, index); }
static void nc_read_resources(struct device *dev)
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)