[S] Change in coreboot[main]: mainboard: Introduce BIOS_SIZE - coreboot-gerrit

17 Mar 2024


      Attention is currently required from: Chen, Gang C, David Hendricks, Jincheng Li, Shuo Liu, TangYiwei.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81320?usp=email )
Change subject: mainboard: Introduce BIOS_SIZE
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/intel/avenuecity_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/81320/comment/9d3bff9c_b88aea50 :
PS1, Line 22: 	mupd->FspmConfig.BiosRegionBase = BASE_4GB - CONFIG_BIOS_SIZE;
            : 		mupd->FspmConfig.BiosRegionSize = CONFIG_BIOS_SIZE;
Why in the mainboard dir and not SOC?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/81320?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5bf8fde9fdc30507ce8eb809f636d02cfa2baf0e
Gerrit-Change-Number: 81320
Gerrit-PatchSet: 1
Gerrit-Owner: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C gang.c.chen@intel.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Jincheng Li jincheng.li@intel.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Chen, Gang C gang.c.chen@intel.com
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Shuo Liu shuo.liu@intel.com
Gerrit-Attention: Jincheng Li jincheng.li@intel.com
Gerrit-Attention: TangYiwei
Gerrit-Comment-Date: Sun, 17 Mar 2024 13:25:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment