Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29470 )
Change subject: mainboard/portwell/m107: Do initial mainboard commit ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig File src/mainboard/portwell/m107/Kconfig:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/Kconfig... PS11, Line 30: choice
These options are used anywhere? […]
There are not GPIO or other possibility to be used to determine the memory type. For this reason this choice is used. romstage.c checks for memory type using ONBOARD_MICRON_MEM. Using this method different binaries can be generated for the HW revisions.
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/acpi/sup... File src/mainboard/portwell/m107/acpi/superio.asl:
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/acpi/sup... PS8, Line 21: Device (COM1) {
What I meant is why the ASL code is shifted by 1 TAB?
My fault. Sorry, indented != intended. Will corrrect this.
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/board_in... File src/mainboard/portwell/m107/board_info.txt:
https://review.coreboot.org/#/c/29470/8/src/mainboard/portwell/m107/board_in... PS8, Line 3: Category: misc
Here's more detailed description of board_info: […]
Will change it to sbc.
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... File src/mainboard/portwell/m107/com_init.c:
https://review.coreboot.org/#/c/29470/11/src/mainboard/portwell/m107/com_ini... PS11, Line 24: void car_mainboard_pre_console_init(void)
Since https://review.coreboot. […]
The UART needs to be configured here as early as possible. Function mainboard_after_memory_init() is used to disable the onboard UART. Otherwise not console output in later stage.