Change in ...coreboot[master]: google/kukui: Move some initialization from bootblock to verstage.

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30331 )

Change subject: google/kukui: Move some initialization from bootblock to verstage.
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefile... 
File src/mainboard/google/kukui/Makefile.inc:

https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/Makefile... 
PS10, Line 10: mainboard.c
Usually mainboard.c is reserved to ramstage, especially that it contains struct for automatically initialization.

I think we should move the init function to something different, for example early_init.c, and leave mainboard.c only for ramstage.

https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboar... 
File src/mainboard/google/kukui/mainboard.c:

https://review.coreboot.org/#/c/30331/10/src/mainboard/google/kukui/mainboar... 
PS10, Line 70: /* Turn on real eMMC. */
             : 	gpio_output(BOOTBLOCK_EN_L, 1);
Can we move this to before mt8183_early_init, or at least before setup_chromeos_gpios? And change the comment to

/* Turn on real eMMC and allow communication to EC. */