HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31598
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
crossgcc: Upgrade GCC to version 8.3.0
Change-Id: I135fd62619fc33bbc3fd29e93eeafcf695700c9a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-8.3.0_gnat.patch R util/crossgcc/patches/gcc-8.3.0_libgcc.patch R util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch D util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum 7 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/31598/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index c19b766..5536d87 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -50,7 +50,7 @@ GMP_VERSION=6.1.2 MPFR_VERSION=4.0.2 MPC_VERSION=1.1.0 -GCC_VERSION=8.2.0 +GCC_VERSION=8.3.0 GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.32 GDB_VERSION=8.2.1 diff --git a/util/crossgcc/patches/gcc-8.2.0_ada-musl_workaround.patch b/util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_ada-musl_workaround.patch rename to util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_gnat.patch b/util/crossgcc/patches/gcc-8.3.0_gnat.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_gnat.patch rename to util/crossgcc/patches/gcc-8.3.0_gnat.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_libgcc.patch b/util/crossgcc/patches/gcc-8.3.0_libgcc.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_libgcc.patch rename to util/crossgcc/patches/gcc-8.3.0_libgcc.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_nds32_ite.patch b/util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_nds32_ite.patch rename to util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch diff --git a/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum deleted file mode 100644 index 1ef301a..0000000 --- a/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -19926bdb6c4b58891015929853d41aeff019d400 tarballs/gcc-8.2.0.tar.xz diff --git a/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum b/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum new file mode 100644 index 0000000..b46ef8c --- /dev/null +++ b/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum @@ -0,0 +1 @@ +c27f4499dd263fe4fb01bcc5565917f3698583b2 tarballs/gcc-8.3.0.tar.xz
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31598 )
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
Patch Set 1:
Did you run test this on QEMU and your board for example? Please add that to the commit message. It’d be also interesting if you did a timeless build for a QEMU board for example, and see if they differ at all: `make BUILD_TIMELESS=1`.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31598 )
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
Patch Set 1:
Did you run test this on QEMU and your board for example? Please add that to the commit message. It’d be also interesting if you did a timeless build for a QEMU board for example, and see if they differ at all: `make BUILD_TIMELESS=1`.
I did the test on my board and it still booting fine. make BUILD_TIMELESS=1 on emulation/qemu-i440fx (QEMU x86 i440fx/piix4) gives me: $ md5sum build/coreboot.rom 7bb779c0c0f99f071eef51ab90483963 build/coreboot.rom this is done on https://review.coreboot.org/#/c/coreboot/+/31593/ with GCC 8.3.0
if you are using gcc 8.2.0, can you check if we have the same md5sum on QEMU x86 i440fx/piix4 (default config and https://review.coreboot.org/#/c/coreboot/+/31593/ ) ?
otherwise, I'll try to step back to older toolchain next week.
HAOUAS Elyes has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/31598 )
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
Removed reviewer build bot (Jenkins).
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31598 )
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
Patch Set 3: Code-Review+2
This change is ready for review.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31598 )
Change subject: crossgcc: Upgrade GCC to version 8.3.0 ......................................................................
crossgcc: Upgrade GCC to version 8.3.0
Change-Id: I135fd62619fc33bbc3fd29e93eeafcf695700c9a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31598 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch R util/crossgcc/patches/gcc-8.3.0_gnat.patch R util/crossgcc/patches/gcc-8.3.0_libgcc.patch R util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch D util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum 7 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 5ee6638..12bb23d 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -50,7 +50,7 @@ GMP_VERSION=6.1.2 MPFR_VERSION=4.0.2 MPC_VERSION=1.1.0 -GCC_VERSION=8.2.0 +GCC_VERSION=8.3.0 GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.32 GDB_VERSION=8.2.1 diff --git a/util/crossgcc/patches/gcc-8.2.0_ada-musl_workaround.patch b/util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_ada-musl_workaround.patch rename to util/crossgcc/patches/gcc-8.3.0_ada-musl_workaround.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_gnat.patch b/util/crossgcc/patches/gcc-8.3.0_gnat.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_gnat.patch rename to util/crossgcc/patches/gcc-8.3.0_gnat.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_libgcc.patch b/util/crossgcc/patches/gcc-8.3.0_libgcc.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_libgcc.patch rename to util/crossgcc/patches/gcc-8.3.0_libgcc.patch diff --git a/util/crossgcc/patches/gcc-8.2.0_nds32_ite.patch b/util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch similarity index 100% rename from util/crossgcc/patches/gcc-8.2.0_nds32_ite.patch rename to util/crossgcc/patches/gcc-8.3.0_nds32_ite.patch diff --git a/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum b/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum deleted file mode 100644 index 1ef301a..0000000 --- a/util/crossgcc/sum/gcc-8.2.0.tar.xz.cksum +++ /dev/null @@ -1 +0,0 @@ -19926bdb6c4b58891015929853d41aeff019d400 tarballs/gcc-8.2.0.tar.xz diff --git a/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum b/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum new file mode 100644 index 0000000..b46ef8c --- /dev/null +++ b/util/crossgcc/sum/gcc-8.3.0.tar.xz.cksum @@ -0,0 +1 @@ +c27f4499dd263fe4fb01bcc5565917f3698583b2 tarballs/gcc-8.3.0.tar.xz
-
HAOUAS Elyes (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)