Attention is currently required from: Caveh Jalali, Eran Mitrani, Hannah Williams, Jamie Ryu, Kapil Porwal, Sukumar Ghorai, Tarun.
Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78322?usp=email )
Change subject: mb/google/rex/var/rex: Configure PL4 to 64W if battery status is invalid
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78322/comment/1e8cf02f_c2a944e2 :
PS5, Line 48: battery_status
this is not a good test. […]
the battery_status is only reading if the returned value from the host command is 0 see https://review.coreboot.org/c/coreboot/+/78321 I'm not sure this is the right way to go about this because that would only matter if the battery is cutoff (physically or by ec command both cause the host command to return 0)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78322?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I12fd40abda76c8e7522b06a5aee72665f32ddec8
Gerrit-Change-Number: 78322
Gerrit-PatchSet: 5
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 12 Oct 2023 20:59:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment