Attention is currently required from: Shelley Chen, Felix Singer, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner, Angel Pons, Arthur Heymans, Yu-Ping Wu.
Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59193 )
Change subject: libpayload: Parse DDR Information using coreboot tables
......................................................................
Patch Set 41:
(2 comments)
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/59193/comment/b73b9a2d_dbc95160
PS40, Line 7: DDR3 = 0x30,
I don't think Julius meant to remove the MEM_CHIP_ prefix.
Done
https://review.coreboot.org/c/coreboot/+/59193/comment/98e70160_5fe4476d
PS40, Line 8: 38
And 40 --> 0x40 as well
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59193
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e
Gerrit-Change-Number: 59193
Gerrit-PatchSet: 41
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Xi Chen
xixi.chen@mediatek.com
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-CC: mturney mturney
quic_mturney@quicinc.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: mturney mturney
quic_mturney@quicinc.com
Gerrit-Comment-Date: Wed, 16 Mar 2022 00:57:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment