Change in coreboot[master]: lib: Fix edge case of log2_ceil() - coreboot-gerrit

2 Dec 2021


      Attention is currently required from: Julius Werner, Yu-Ping Wu.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59834 )
Change subject: lib: Fix edge case of log2_ceil()
......................................................................
Patch Set 1:
(1 comment)
File tests/lib/lib-test.c:
https://review.coreboot.org/c/coreboot/+/59834/comment/8fccd3fe_c9c3f83d 
PS1, Line 46: log2_ceil(0xffffffff)
In the original implementation this will be 31:
log2_ceil(0xffffffff)
 = log2((u32)0xffffffff * 2 - 1)
 = log2(0xfffffffd)
 = 31
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59834
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If868f793b909a6ad7fc48a7affac15e2c714fa2e
Gerrit-Change-Number: 59834
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Jakub Czapiga jacz@semihalf.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-CC: Jianjun Wang jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 08:20:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment