build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 )
Change subject: drivers/spi: Winbond specific write-protection enable ......................................................................
Patch Set 20:
(7 comments)
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@33 PS20, Line 33: #define CMD_VOLATILE_SREG_WREN 0x50 /* Write Enable for Volatile Status Register */ line over 80 characters
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@506 PS20, Line 506: val = (union status_reg1_bp3){ .bp = bp, .tb = tb, .sec = 0 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@507 PS20, Line 507: mask = (union status_reg1_bp3){ .bp = ~0, .tb = 1, .sec = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@509 PS20, Line 509: val = (union status_reg1_bp4){ .bp = bp, .tb = tb }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@510 PS20, Line 510: mask = (union status_reg1_bp4){ .bp = ~0, .tb = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@517 PS20, Line 517: val = (union status_reg2){ .cmp = cmp }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/25105/20/src/drivers/spi/winbond.c@518 PS20, Line 518: mask = (union status_reg2){ .cmp = 1 }.u; space required after that close brace '}'
-
build bot (Jenkins) (Code Review)