Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41624 )
Change subject: drivers/intel/mipi_camera: Support adding camera power resource
......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41624/12/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/41624/12/src/drivers/intel/mipi_cam...
PS12, Line 537: acpigen_write_store_op_to_namestr(0, "STA");
This implementation is based on some of the older platforms PowerResource. […]
OS can guarantee for a specific device, _ON and _OFF are called appropriately.
But if multiple devices share the same power resource, OS does not know this.
such cases do exists. Like camera sensor, eeprom and the VCM(device that control lens position) share the same power rails.
Also for some platforms, worldfacing and userfacing cameras share the same power rails.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31e198b50acf2c64035aff9cb054fbe3602dd83e
Gerrit-Change-Number: 41624
Gerrit-PatchSet: 16
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kiran2 Kumar
kiran2.kumar@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 14:01:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-MessageType: comment