[XS] Change in coreboot[main]: soc/mediatek/mt8196: Add mtk-fsp loader in romstage - coreboot-gerrit

16 Jan 2025


      Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86014?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in romstage
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/86014/comment/2cb191ab_919ae1ac?usp... :
PS2, Line 60: FSP_INIT_CODE
...
The symbol is conflict with one in the ramstage, right ? […]
Right. Even if this compiles, it's better to have separate `FSP_ROMSTAGE_INIT_CODE` and `FSP_RAMSTAGE_INIT_CODE`.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86014?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I73710227e6d9e3f0c717e17db0cc798265eb1f72
Gerrit-Change-Number: 86014
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Jarried Lin jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 07:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin yidilin@google.com