Change in coreboot[master]: arch/x86/acpi_bert_storage: change return type of bert_errors_present - coreboot-gerrit

28 May 2021


      Attention is currently required from: Angel Pons.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55023 )
Change subject: arch/x86/acpi_bert_storage: change return type of bert_errors_present
......................................................................
Patch Set 4:
(1 comment)
File src/arch/x86/acpi_bert_storage.c:
https://review.coreboot.org/c/coreboot/+/55023/comment/2b6bcc3f_8ac1c3dc 
PS3, Line 38: !!
...
the double negation is not needed.
as expected the resulting binary stays the same in a timeless build
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d6472deeb26ba92d257761df069e32d9b2e5d4
Gerrit-Change-Number: 55023
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 28 May 2021 18:15:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment