Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39638 )
Change subject: drivers/intel/gma: hook up GMA for Skylake+
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39638/12/src/soc/intel/skylake/acpi...
File src/soc/intel/skylake/acpi/pch.asl:
https://review.coreboot.org/c/coreboot/+/39638/12/src/soc/intel/skylake/acpi...
PS12, Line 32: /* IGD 0:2.0 */
For this generation, the IGD is still spread across both chips and the ACPI relevant part […]
You're right, it's quite confusing. In the EDS figure 2-6 it's shown in the Processor part. But the South BLM control is indeed in the PCH.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c2f0e8fe1ef91334d494c8a8605dd46cda80e3d
Gerrit-Change-Number: 39638
Gerrit-PatchSet: 12
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 12:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-MessageType: comment