Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27590 )
Change subject: nb/i945: Fix sdram_rcomp_buffer_strength_and_slew for i945GC ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG@7 PS14, Line 7: Fix nit: consider that the values might be for the "DIMM on slot 0 only" case.
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG@9 PS14, Line 9: vendorbios vendor BIOS
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG@9 PS14, Line 9: dual dual... dual what? Rank, DIMM, channel? 😄
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG@9 PS14, Line 9: vales values
https://review.coreboot.org/c/coreboot/+/27590/14//COMMIT_MSG@12 PS14, Line 12: not nit: does not