Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29976 )
Change subject: sb/intel/lynxpoint: Ensure the finalise handler is called
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc....
File src/southbridge/intel/lynxpoint/lpc.c:
https://review.coreboot.org/#/c/29976/1/src/southbridge/intel/lynxpoint/lpc....
PS1, Line 972: acpi_is_wakeup_s3() || IS_ENABLED(C
Should be selected by lynxpoint/Kconfig (instead of every single […]
Done. I moved the option in Kconfig in a separate patch:
https://review.coreboot.org/29992
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9766a8dcbcb38420e937c810d252fef071851e92
Gerrit-Change-Number: 29976
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 01 Dec 2018 14:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment