Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25446 )
Change subject: soc/intel/denverton_ns: Generate ACPI DMAR Table ......................................................................
Patch Set 22:
(5 comments)
Wow by the time I got there most of the code was already fixed, thanks community!
https://review.coreboot.org/c/coreboot/+/25446/4/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/acpi.c:
https://review.coreboot.org/c/coreboot/+/25446/4/src/soc/intel/denverton_ns/... PS4, Line 367: /* reusing drdh functions for rmrr. : * Should be Device Scope? : * IE remove _drhd */
If you make the suggested changes I put in the other patch, then you can change this to call acpi_cr […]
The suggestion has been implemented already by now... thanks!
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns... File src/soc/intel/denverton_ns/acpi.c:
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns... PS18, Line 339: MCH_VTBAR_MASK;
nit: this would fit in 96 chars
Done
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns... PS18, Line 354: fsp
FSP
Done
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns... PS18, Line 359: drdh
DRHD
Ack
https://review.coreboot.org/c/coreboot/+/25446/4/src/soc/intel/denverton_ns/... File src/soc/intel/denverton_ns/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/25446/4/src/soc/intel/denverton_ns/... PS4, Line 80: 0xfffff000
I mean 0x7ffffff000... […]
Done
-
Julien Viard de Galbert (Code Review)