Attention is currently required from: Hung-Te Lin, Kyösti Mälkki.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50879 )
Change subject: [WIP] ChromeOS: Move watchdog_tombstone and TPM reset triggers
......................................................................
Patch Set 9:
(2 comments)
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/50879/comment/3722b802_4a986b74
PS9, Line 904: elog_handle_watchdog_tombstone
nit: maybe elog_watchdog_event() or something like that instead, since the tombstone thing is just one of the two ways to get it?
File src/lib/watchdog.c:
PS9:
Needs a Makefile rule in the new location?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40b72cd63b051a2649ff450f50946e5a0a00ed4f
Gerrit-Change-Number: 50879
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 21:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment