Attention is currently required from: Marc Jones, Jonathan Zhang, Johnny Lin, Jingle Hsu, Subrata Banik, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59857 )
Change subject: soc/intel/common/pch: Fix the comment typos for CHIPSET_LOCKDOWN
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59857/comment/2169cf69_19c858b3
PS3, Line 2: JingleHsuWiwynn
Jingle Hsu
$ git config --global user.name "Jingle Hsu"
$ git commit --amend --author="Jingle Hsu jingle_hsu@wiwynn.com"
https://review.coreboot.org/c/coreboot/+/59857/comment/8c56669b_3d734345
PS3, Line 7: Fix the comment typos for CHIPSET_LOCKDOWN
Maybe:
Fix return value documentation for CHIPSET_LOCKDOWN
https://review.coreboot.org/c/coreboot/+/59857/comment/a92954c7_f0b17c21
PS3, Line 12: JingleHsuWiwynn
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59857
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50dbc00806fefda8f4dac8bfa21dc714a9504566
Gerrit-Change-Number: 59857
Gerrit-PatchSet: 3
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 03 Dec 2021 13:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment