Change in coreboot[master]: mb/google/dedede/variants: Add support for charger throttling

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Sumeet R Pawnikar (Code Review)

4 Jan 2021 4 Jan '21

4:35 a.m.

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49083 )

Change subject: mb/google/dedede/variants: Add support for charger throttling ......................................................................

mb/google/dedede/variants: Add support for charger throttling

Add charger current throttling support

BUG=None BRANCH=None TEST=Built and tested on boten system

Change-Id: I79edba579249111294a982590660196f05be7eaf Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/49083/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 2785ad0..e9b11ba 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -230,6 +230,14 @@ register "options.tsr[0].desc" = ""Memory"" register "options.tsr[1].desc" = ""Ambient""

+ ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 3000 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 } + }" + device generic 0 on end end end # SA Thermal device

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Sumeet R Pawnikar (Code Review)

5 Jan 5 Jan

4:07 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49083

to look at the new patch set (#2).

Change subject: mb/google/dedede/variants: Add support for charger throttling ......................................................................

mb/google/dedede/variants: Add support for charger throttling

Add charger current throttling support for dedede variants

BUG=None BRANCH=None TEST=Built and tested on boten system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/49083/2

Karthik Ramasubramanian (Code Review)

11:27 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49083 )

Change subject: mb/google/dedede/variants: Add support for charger throttling ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG@7 PS2, Line 7: variants Nit: No need to mention variants.

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG@9 PS2, Line 9: variants Nit: baseboard.

-- To view, visit https://review.coreboot.org/c/coreboot/+/49083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79edba579249111294a982590660196f05be7eaf Gerrit-Change-Number: 49083 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 06:27:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Sumeet R Pawnikar (Code Review)

11:45 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add support for charger throttling

Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/49083

to look at the new patch set (#3).

Change subject: mb/google/dedede: Add support for charger throttling ......................................................................

mb/google/dedede: Add support for charger throttling

Add charger current throttling support for dedede baseboard

BUG=None BRANCH=None TEST=Built and tested on boten system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/49083/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/49083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79edba579249111294a982590660196f05be7eaf Gerrit-Change-Number: 49083 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Sumeet R Pawnikar (Code Review)

11:45 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add support for charger throttling

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49083 )

Change subject: mb/google/dedede: Add support for charger throttling ......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG@7 PS2, Line 7: variants

...

Nit: No need to mention variants.

Ack

https://review.coreboot.org/c/coreboot/+/49083/2//COMMIT_MSG@9 PS2, Line 9: variants

...

Nit: baseboard.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/49083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79edba579249111294a982590660196f05be7eaf Gerrit-Change-Number: 49083 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 06:45:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

6 Jan 6 Jan

4:08 p.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add support for charger throttling

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49083 )

Change subject: mb/google/dedede: Add support for charger throttling ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/49083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79edba579249111294a982590660196f05be7eaf Gerrit-Change-Number: 49083 Gerrit-PatchSet: 3 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 06 Jan 2021 23:08:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Jan 7 Jan

4:32 a.m.

New subject: Change in coreboot[master]: mb/google/dedede: Add support for charger throttling

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49083 )

Change subject: mb/google/dedede: Add support for charger throttling ......................................................................

mb/google/dedede: Add support for charger throttling

Add charger current throttling support for dedede baseboard

BUG=None BRANCH=None TEST=Built and tested on boten system

Change-Id: I79edba579249111294a982590660196f05be7eaf Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/49083 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/baseboard/devicetree.cb 1 file changed, 13 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb index 2785ad0..bb76c9c 100644 --- a/src/mainboard/google/dedede/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/dedede/variants/baseboard/devicetree.cb @@ -199,14 +199,16 @@ register "policies.passive" = "{ [0] = DPTF_PASSIVE(CPU, CPU, 90, 10000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 80, 60000), - [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 55, 15000) + [2] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 55, 15000), + [3] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_2, 75, 15000) }"

## Critical Policy register "policies.critical" = "{ [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 90, SHUTDOWN), - [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN) + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 80, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 90, SHUTDOWN) }"

## Power Limits Control @@ -229,6 +231,15 @@

register "options.tsr[0].desc" = ""Memory"" register "options.tsr[1].desc" = ""Ambient"" + register "options.tsr[2].desc" = ""Charger"" + + ## Charger Performance Control (Control, mA) + register "controls.charger_perf" = "{ + [0] = { 255, 3000 }, + [1] = { 24, 1500 }, + [2] = { 16, 1000 }, + [3] = { 8, 500 } + }"

device generic 0 on end end

-- To view, visit https://review.coreboot.org/c/coreboot/+/49083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79edba579249111294a982590660196f05be7eaf Gerrit-Change-Number: 49083 Gerrit-PatchSet: 4 Gerrit-Owner: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1589

days inactive

1592

days old

coreboot-gerrit@coreboot.org

6 comments

3 participants

tags (0)

participants (3)

Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)
Sumeet R Pawnikar (Code Review)