[M] Change in coreboot[master]: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC

[Paul Menzel (Code Review)]

Attention is currently required from: Tim Crawford, Jeremy Soller, Angel Pons, Jonathon Hall, Felix Held.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74364 )

Change subject: src/mb/purism/librem_cnl: Enable Librem 14 jack detect with fixed EC
......................................................................

Patch Set 1:

(13 comments)

Patchset:

PS1: 
If possible, it’d be nice to split the mainboard change out into a separate commit.

File src/ec/purism/librem-ec/librem_ec.h:

https://review.coreboot.org/c/coreboot/+/74364/comment/c7c3611e_1e2919ca 
PS1, Line 9: update
If you know the version, please mention it.

https://review.coreboot.org/c/coreboot/+/74364/comment/487dec2e_8ff51d8a 
PS1, Line 8: /* Check whether librem-ec has working jack detect.  This was fixed in an
           :  * update, so we only use the verbs with jack detect if the EC has been updated.
           :  */
Please use the recommended multi-line comment style.

File src/ec/purism/librem-ec/librem_ec.c:

https://review.coreboot.org/c/coreboot/+/74364/comment/eab5594e_65bd8bcb 
PS1, Line 11: /* The 'flags' field in the probe command reply was added in an update.
            : 	 * Send 4 bytes of zeroes in the "request" to zero out the field if the
            : 	 * EC does not set it for its reply. */
Please use the recommended multi-line comment style.

https://review.coreboot.org/c/coreboot/+/74364/comment/6c02ad7a_1230d3b0 
PS1, Line 17: reply_data, ARRAY_SIZE(reply_data)))
            : 		return false;
Aligning both lines the same is a little confusing to me. No idea, what `indent` or `clang-format` does.

File src/ec/system76/ec/system76_ec.h:

https://review.coreboot.org/c/coreboot/+/74364/comment/a556f4ec_b5f787a1 
PS1, Line 9: /* Send a command to the EC.  request_data/request_size are the request payload,
           :  * request_data can be NULL if request_size is 0.  reply_data/reply_size are
           :  * the reply payload, reply_data can be NULL if reply_size is 0. */
Please use the recommended multi-line comment style.

File src/ec/system76/ec/system76_ec.c:

https://review.coreboot.org/c/coreboot/+/74364/comment/e2c5dcfa_a19a09f6 
PS1, Line 84: 	uint8_t i;
No need to limit the length.

https://notabs.org/coding/smallIntsBigPenalty.htm

https://review.coreboot.org/c/coreboot/+/74364/comment/516fae9d_b059b227 
PS1, Line 86: REG_DATA+i
Please spaces around the operator.

https://review.coreboot.org/c/coreboot/+/74364/comment/5ee087db_c0688d6f 
PS1, Line 96: 		ret = false;
Log an error?

File src/mainboard/purism/librem_cnl/variants/librem_14/hda_verb.c:

https://review.coreboot.org/c/coreboot/+/74364/comment/239b9f21_d2cae7cc 
PS1, Line 64: /* Older verbs with no jack detect - needed if an older Librem EC is in use that
            :  * lacks jack detect.  Headphones can be selected manually. */
Please use the recommended multi-line comment style.

https://review.coreboot.org/c/coreboot/+/74364/comment/34392bab_fcd88430 
PS1, Line 74: /* Now that the codec is configured, we can check if the EC has
            : 		 * jack detect. */
Please use the recommended multi-line comment style.

https://review.coreboot.org/c/coreboot/+/74364/comment/f2b49096_12aabe0b 
PS1, Line 79: printk(BIOS_WARNING, "EC firmware lacks jack detect, applying workaround\n");
Add a comment to update the EC firmware?

https://review.coreboot.org/c/coreboot/+/74364/comment/42411afd_76eb3b80 
PS1, Line 80: /* The EC firmware lacks jack detect.  Program the
            : 			 * older workaround verbs with no jack detect. */
Please use the recommended multi-line comment style.