Attention is currently required from: Furquan Shaikh, Paul Fagerburg.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50449 )
Change subject: mb/google: order matters in mem_parts_used.txt
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
I updated the ones for dedede and volteer. […]
The comment still makes sense. You can mix and match assigned and unassigned ids. The order of the unassigned ids is what matters. Thanks for pushing this through. +2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50449
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iffbd8e69a89b1b7c810c5d25c7a6148d459d8b02
Gerrit-Change-Number: 50449
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Comment-Date: Tue, 09 Feb 2021 23:02:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment