build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25372 )
Change subject: sdm845: Add QUPv3 FW load & config
......................................................................
Patch Set 76:
(3 comments)
https://review.coreboot.org/#/c/25372/76/src/soc/qualcomm/sdm845/include/soc...
File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:
https://review.coreboot.org/#/c/25372/76/src/soc/qualcomm/sdm845/include/soc...
PS76, Line 237: enum qup_se se;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25372/76/src/soc/qualcomm/sdm845/include/soc...
PS76, Line 238: enum se_protocol protocol;
please, no spaces at the start of a line
https://review.coreboot.org/#/c/25372/76/src/soc/qualcomm/sdm845/include/soc...
PS76, Line 239: enum se_mode mode;
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e87f868ecbe2a8e51d94c045ad76b99bb1b345d
Gerrit-Change-Number: 25372
Gerrit-PatchSet: 76
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mukesh Savaliya
msavaliy@qualcomm.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Akash Asthana
akashast@qualcomm.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 26 Jun 2019 14:59:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment