Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32809 )
Change subject: src/southbridge: Add missing 'include <types.h>' ......................................................................
src/southbridge: Add missing 'include <types.h>'
<types.h> is supposed to provide <stdint.h> and <stddef.h>. When <types.h> is included, <stdint.h> and/or <stddef.h> is removed.
Change-Id: I4d8628e4ce3c7f80da2590b4cad618b290e0d513 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32809 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com --- M src/southbridge/amd/pi/hudson/hudson.c M src/southbridge/amd/pi/hudson/lpc.c M src/southbridge/amd/sb700/ide.c M src/southbridge/amd/sb700/sata.c M src/southbridge/amd/sb700/usb.c M src/southbridge/intel/bd82x6x/sata.c M src/southbridge/intel/common/smbus.c M src/southbridge/intel/i82801ix/sata.c M src/southbridge/intel/i82801jx/sata.c M src/southbridge/intel/ibexpeak/sata.c 10 files changed, 24 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/southbridge/amd/pi/hudson/hudson.c b/src/southbridge/amd/pi/hudson/hudson.c index e1ea2ce..a331c57 100644 --- a/src/southbridge/amd/pi/hudson/hudson.c +++ b/src/southbridge/amd/pi/hudson/hudson.c @@ -14,16 +14,16 @@ */
#include <console/console.h> - #include <arch/io.h> #include <device/mmio.h> #include <arch/acpi.h> - #include <device/device.h> #include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <types.h> + #include "hudson.h" #include "smbus.h" #include "smi.h" diff --git a/src/southbridge/amd/pi/hudson/lpc.c b/src/southbridge/amd/pi/hudson/lpc.c index abb92f2..5354a27 100644 --- a/src/southbridge/amd/pi/hudson/lpc.c +++ b/src/southbridge/amd/pi/hudson/lpc.c @@ -27,6 +27,8 @@ #include <arch/acpi.h> #include <pc80/i8254.h> #include <pc80/i8259.h> +#include <types.h> + #include "hudson.h" #include "pci_devs.h"
diff --git a/src/southbridge/amd/sb700/ide.c b/src/southbridge/amd/sb700/ide.c index 6734643..0b11db3 100644 --- a/src/southbridge/amd/sb700/ide.c +++ b/src/southbridge/amd/sb700/ide.c @@ -19,6 +19,8 @@ #include <device/pci_ids.h> #include <device/pci_ops.h> #include <option.h> +#include <types.h> + #include "sb700.h"
static void ide_init(struct device *dev) diff --git a/src/southbridge/amd/sb700/sata.c b/src/southbridge/amd/sb700/sata.c index 39aef63..292a7f2 100644 --- a/src/southbridge/amd/sb700/sata.c +++ b/src/southbridge/amd/sb700/sata.c @@ -23,6 +23,8 @@ #include <arch/io.h> #include <device/mmio.h> #include <option.h> +#include <types.h> + #include "sb700.h"
static int sata_drive_detect(int portnum, uint16_t iobar) diff --git a/src/southbridge/amd/sb700/usb.c b/src/southbridge/amd/sb700/usb.c index da65311..4109e88 100644 --- a/src/southbridge/amd/sb700/usb.c +++ b/src/southbridge/amd/sb700/usb.c @@ -21,6 +21,8 @@ #include <device/pci_ehci.h> #include <device/mmio.h> #include <option.h> +#include <types.h> + #include "sb700.h"
static struct pci_operations lops_pci = { diff --git a/src/southbridge/intel/bd82x6x/sata.c b/src/southbridge/intel/bd82x6x/sata.c index 91c87bf..6a39873 100644 --- a/src/southbridge/intel/bd82x6x/sata.c +++ b/src/southbridge/intel/bd82x6x/sata.c @@ -20,9 +20,11 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include "pch.h" #include <pc80/mc146818rtc.h> #include <acpi/sata.h> +#include <types.h> + +#include "pch.h"
typedef struct southbridge_intel_bd82x6x_config config_t;
diff --git a/src/southbridge/intel/common/smbus.c b/src/southbridge/intel/common/smbus.c index 4b08c48..af1eb60 100644 --- a/src/southbridge/intel/common/smbus.c +++ b/src/southbridge/intel/common/smbus.c @@ -19,6 +19,8 @@ #include <console/console.h> #include <device/smbus_def.h> #include <stdlib.h> +#include <types.h> + #include "smbus.h"
diff --git a/src/southbridge/intel/i82801ix/sata.c b/src/southbridge/intel/i82801ix/sata.c index 6155c15..49d2d36 100644 --- a/src/southbridge/intel/i82801ix/sata.c +++ b/src/southbridge/intel/i82801ix/sata.c @@ -22,8 +22,10 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include "i82801ix.h" #include <pc80/mc146818rtc.h> +#include <types.h> + +#include "i82801ix.h"
typedef struct southbridge_intel_i82801ix_config config_t;
diff --git a/src/southbridge/intel/i82801jx/sata.c b/src/southbridge/intel/i82801jx/sata.c index 8de2d74..ddaa783 100644 --- a/src/southbridge/intel/i82801jx/sata.c +++ b/src/southbridge/intel/i82801jx/sata.c @@ -22,8 +22,10 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include "i82801jx.h" #include <pc80/mc146818rtc.h> +#include <types.h> + +#include "i82801jx.h"
typedef struct southbridge_intel_i82801jx_config config_t;
diff --git a/src/southbridge/intel/ibexpeak/sata.c b/src/southbridge/intel/ibexpeak/sata.c index 112445b..e03f8b5 100644 --- a/src/southbridge/intel/ibexpeak/sata.c +++ b/src/southbridge/intel/ibexpeak/sata.c @@ -21,9 +21,11 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> -#include "pch.h" #include <pc80/mc146818rtc.h> #include <acpi/sata.h> +#include <types.h> + +#include "pch.h"
typedef struct southbridge_intel_ibexpeak_config config_t;
-
Patrick Georgi (Code Review)