Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60392 )
Change subject: soc/mediatek: Prevent passing NULL MIPI commands ......................................................................
soc/mediatek: Prevent passing NULL MIPI commands
Previously (before CB:56965) mtk_dsi_send_init_command() would ignore NULL initialization commands passed to it. However, in the current code mipi_panel_parse_init_commands() doesn't check that (see CB:57150), so we should check it on the caller side from mtk_dsi_init().
BUG=b:202871018, b:209930699 TEST=emerge-corsola coreboot BRANCH=none
Change-Id: I8196e3b135da273325e2e121523abb7fb230a49c Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M src/soc/mediatek/common/dsi.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/60392/1
diff --git a/src/soc/mediatek/common/dsi.c b/src/soc/mediatek/common/dsi.c index a4556f5..f16d8f2 100644 --- a/src/soc/mediatek/common/dsi.c +++ b/src/soc/mediatek/common/dsi.c @@ -377,7 +377,8 @@ mtk_dsi_clk_hs_mode_disable(); mtk_dsi_config_vdo_timing(mode_flags, format, lanes, edid, &phy_timing); mtk_dsi_clk_hs_mode_enable(); - mipi_panel_parse_init_commands(init_commands, mtk_dsi_cmdq); + if (init_commands) + mipi_panel_parse_init_commands(init_commands, mtk_dsi_cmdq); mtk_dsi_set_mode(mode_flags); mtk_dsi_start();