Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86619?usp=email )
Change subject: soc/amd/common/block: Enable MMCONF first ......................................................................
soc/amd/common/block: Enable MMCONF first
Enabling MMCONF is simple and should be done first to allow bootblock code to access the PCI config space. Required to cache ROM3 in early_cache_setup() that is now called directly after enabling MMCONF.
Change-Id: I5d5f533258985211afafd9bf748f8e26f6128bd4 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/soc/amd/common/block/cpu/noncar/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/86619/1
diff --git a/src/soc/amd/common/block/cpu/noncar/bootblock.c b/src/soc/amd/common/block/cpu/noncar/bootblock.c index e32499d..419510e 100644 --- a/src/soc/amd/common/block/cpu/noncar/bootblock.c +++ b/src/soc/amd/common/block/cpu/noncar/bootblock.c @@ -12,9 +12,9 @@
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { + enable_pci_mmconf(); early_cache_setup(); write_resume_eip(); - enable_pci_mmconf();
if (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)) boot_with_psp_timestamp(base_timestamp);