Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/20830
Change subject: soc/intel/apollolake: Skip disabled IGD device ......................................................................
soc/intel/apollolake: Skip disabled IGD device
If IGD PCI device is disabled: 1. BAR for the device will be 0. 2. There is no need to allocate framebuffer for this device.
Some early SOCs don't have GFX model fuse by default hence we need to add a check to ensure PCI device is enable. This code to avoid die inside coreboot for missing resources.
Change-Id: Ied677e8c77fa7b166b016da458caad0e4702b5d8 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/apollolake/graphics.c 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/20830/1
diff --git a/src/soc/intel/apollolake/graphics.c b/src/soc/intel/apollolake/graphics.c index c873825..90859d5 100644 --- a/src/soc/intel/apollolake/graphics.c +++ b/src/soc/intel/apollolake/graphics.c @@ -27,7 +27,13 @@
uintptr_t fsp_soc_get_igd_bar(void) { - return find_resource(SA_DEV_IGD, PCI_BASE_ADDRESS_2)->base; + device_t dev = SA_DEV_IGD; + + /* Check if IGD PCI device is disabled */ + if (!dev->enabled) + return 0; + + return find_resource(dev, PCI_BASE_ADDRESS_2)->base; }
static void igd_set_resources(struct device *dev)