Attention is currently required from: Michał Żygowski, Christian Walter. Hello Michał Żygowski,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/62493
to review the following change.
Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path ......................................................................
drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
Windows 11 expect the TPM to reside under \_SB_.PCI0 in ACPI device hierarchy, otherwise the TPM is not detected. Hardcode the path to fix the issue
TEST=Boot Windows 11 on Clevo NV41MZ and see the TPm is detected correctly
Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424 --- M src/drivers/pc80/tpm/tis.c 1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62493/1
diff --git a/src/drivers/pc80/tpm/tis.c b/src/drivers/pc80/tpm/tis.c index 455bcf9..cf46f76 100644 --- a/src/drivers/pc80/tpm/tis.c +++ b/src/drivers/pc80/tpm/tis.c @@ -779,12 +779,8 @@ #if CONFIG(HAVE_ACPI_TABLES) static void lpc_tpm_fill_ssdt(const struct device *dev) { - const char *path = acpi_device_path(dev->bus->dev); - - if (!path) { - path = "\_SB_.PCI0.LPCB"; - printk(BIOS_DEBUG, "Using default TPM ACPI path: '%s'\n", path); - } + /* Windows 11 requires the following path for TPM to be detected */ + const char *path = "\_SB_.PCI0";
/* Device */ acpigen_write_scope(path);