HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36927 )
Change subject: mb/(i945): Remove redundant pci_mmio_size ......................................................................
mb/(i945): Remove redundant pci_mmio_size
i945/raminit.c will set pci_mmio_size to DEFAULT_PCI_MMIO_SIZE if the value isless than 768 (see line #1223)
Change-Id: I50bf833383e8d06f73e05113cb92fdbbf39fdad6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/getac/p470/devicetree.cb M src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb M src/mainboard/ibase/mb899/devicetree.cb M src/mainboard/intel/d945gclf/devicetree.cb M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb 9 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36927/1
diff --git a/src/mainboard/apple/macbook21/devicetree.cb b/src/mainboard/apple/macbook21/devicetree.cb index 137c8fc..3e3ca38 100644 --- a/src/mainboard/apple/macbook21/devicetree.cb +++ b/src/mainboard/apple/macbook21/devicetree.cb @@ -35,8 +35,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on # Host bridge subsystemid 0x8086 0x7270 diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index e2001d9..0620416 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -25,8 +25,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on end # host bridge device pci 01.0 off end # i945 PCIe root port diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb index ff5d57b..7ecaf28 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb @@ -25,8 +25,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on # host bridge subsystemid 0x1458 0x5000 diff --git a/src/mainboard/ibase/mb899/devicetree.cb b/src/mainboard/ibase/mb899/devicetree.cb index 78743bd..1f0c76b 100644 --- a/src/mainboard/ibase/mb899/devicetree.cb +++ b/src/mainboard/ibase/mb899/devicetree.cb @@ -9,8 +9,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on end # host bridge device pci 01.0 off end # i945 PCIe root port diff --git a/src/mainboard/intel/d945gclf/devicetree.cb b/src/mainboard/intel/d945gclf/devicetree.cb index 7114a29..23723c7 100644 --- a/src/mainboard/intel/d945gclf/devicetree.cb +++ b/src/mainboard/intel/d945gclf/devicetree.cb @@ -21,8 +21,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on subsystemid 0x8086 0x464c inherit device pci 00.0 on end # host bridge diff --git a/src/mainboard/kontron/986lcd-m/devicetree.cb b/src/mainboard/kontron/986lcd-m/devicetree.cb index 741c47b..377d496 100644 --- a/src/mainboard/kontron/986lcd-m/devicetree.cb +++ b/src/mainboard/kontron/986lcd-m/devicetree.cb @@ -9,8 +9,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on end # host bridge device pci 01.0 off end # i945 PCIe root port diff --git a/src/mainboard/lenovo/t60/devicetree.cb b/src/mainboard/lenovo/t60/devicetree.cb index ada50f3..2c80dc2 100644 --- a/src/mainboard/lenovo/t60/devicetree.cb +++ b/src/mainboard/lenovo/t60/devicetree.cb @@ -35,8 +35,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on # Host bridge subsystemid 0x17aa 0x2015 diff --git a/src/mainboard/lenovo/x60/devicetree.cb b/src/mainboard/lenovo/x60/devicetree.cb index 1a914fd..54c4e81 100644 --- a/src/mainboard/lenovo/x60/devicetree.cb +++ b/src/mainboard/lenovo/x60/devicetree.cb @@ -35,8 +35,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on device pci 00.0 on # Host bridge subsystemid 0x17aa 0x2017 diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index 5bce304..91601d2 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -25,8 +25,6 @@ end end
- register "pci_mmio_size" = "768" - device domain 0 on subsystemid 0x4352 0x6886 inherit device pci 00.0 on end # host bridge
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36927 )
Change subject: mb/(i945): Remove redundant pci_mmio_size ......................................................................
Patch Set 1:
IIRC, the reasoning was that this way it is more visible where one could change it [1]. I still have no strong opinion, so Arthur will have to have one ;)
[1] https://review.coreboot.org/c/coreboot/+/16856/13..15#message-51978132245609...
Hello Alexander Couzens, Evgeny Zinoviev, Patrick Rudolph, Arthur Heymans, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36927
to look at the new patch set (#2).
Change subject: mb/(i945): Remove redundant pci_mmio_size ......................................................................
mb/(i945): Remove redundant pci_mmio_size
i945/raminit.c will set pci_mmio_size to DEFAULT_PCI_MMIO_SIZE if the value is less than 768 (see line #1223)
Change-Id: I50bf833383e8d06f73e05113cb92fdbbf39fdad6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/apple/macbook21/devicetree.cb M src/mainboard/getac/p470/devicetree.cb M src/mainboard/gigabyte/ga-945gcm-s2l/devicetree.cb M src/mainboard/ibase/mb899/devicetree.cb M src/mainboard/intel/d945gclf/devicetree.cb M src/mainboard/kontron/986lcd-m/devicetree.cb M src/mainboard/lenovo/t60/devicetree.cb M src/mainboard/lenovo/x60/devicetree.cb M src/mainboard/roda/rk886ex/devicetree.cb 9 files changed, 0 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/36927/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36927 )
Change subject: mb/(i945): Remove redundant pci_mmio_size ......................................................................
Abandoned
see https://review.coreboot.org/c/coreboot/+/16856/