Attention is currently required from: Maulik V Vaghela.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59665 )
Change subject: drivers/intel/usb4/retimer: Add function to correct EC port mapping
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/59665/comment/33bd688c_42a530ed
PS11, Line 458: __weak int retimer_get_index_for_typec(uint8_t typec_port)
: {
: /* By default assume that retimer port index = Type C port */
: return (int)typec_port;
: }
:
why use a weak function when each soc has to implement it anyways?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59665
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7a5e63838e6529196bd211516e4d665b084f79e
Gerrit-Change-Number: 59665
Gerrit-PatchSet: 11
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 22:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment