Change in coreboot[master]: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typo on EcDefaultMessage
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typo on EcDefaultMessage ......................................................................
mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typo on EcDefaultMessage
Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c 7 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/38609/1
diff --git a/src/mainboard/amd/olivehill/BiosCallOuts.c b/src/mainboard/amd/olivehill/BiosCallOuts.c index 4f780b3..9e514b3 100644 --- a/src/mainboard/amd/olivehill/BiosCallOuts.c +++ b/src/mainboard/amd/olivehill/BiosCallOuts.c @@ -156,8 +156,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c index 59d6bf6..8c115d8 100644 --- a/src/mainboard/amd/parmer/BiosCallOuts.c +++ b/src/mainboard/amd/parmer/BiosCallOuts.c @@ -156,8 +156,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/amd/thatcher/BiosCallOuts.c b/src/mainboard/amd/thatcher/BiosCallOuts.c index f8b7539..df256e7 100644 --- a/src/mainboard/amd/thatcher/BiosCallOuts.c +++ b/src/mainboard/amd/thatcher/BiosCallOuts.c @@ -156,8 +156,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/bap/ode_e20XX/BiosCallOuts.c b/src/mainboard/bap/ode_e20XX/BiosCallOuts.c index 9ebef55..e67ae6b 100644 --- a/src/mainboard/bap/ode_e20XX/BiosCallOuts.c +++ b/src/mainboard/bap/ode_e20XX/BiosCallOuts.c @@ -160,8 +160,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c index 0caa718..d366dab 100644 --- a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c +++ b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c @@ -156,8 +156,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c b/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c index a3fbb25..06d9ed6 100644 --- a/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c +++ b/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c @@ -156,8 +156,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwride it. * so we remove it from AGESA code. Please Seee FchInitLateHwm. */ } else { diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c index 876b524..6008658 100644 --- a/src/mainboard/lenovo/g505s/BiosCallOuts.c +++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c @@ -155,8 +155,8 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwrite it. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA put EcDefaultMessage as global data in ROM, so we can't overwrite it. * so we remove it from AGESA code. Please See FchInitLateHwm. */ } else {
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typo on EcDefaultMessage ......................................................................
Patch Set 1: Code-Review+2
This change is pure cosmetic one.
Hello Alexander Couzens, Patrick Rudolph, Peter Lemenkov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38609
to look at the new patch set (#2).
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos
Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c 7 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/38609/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
Patch Set 2:
(12 comments)
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/olivehill... File src/mainboard/amd/olivehill/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/olivehill... PS2, Line 104: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/olivehill... PS2, Line 164: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/parmer/Bi... File src/mainboard/amd/parmer/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/parmer/Bi... PS2, Line 104: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/parmer/Bi... PS2, Line 164: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/thatcher/... File src/mainboard/amd/thatcher/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/thatcher/... PS2, Line 104: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/amd/thatcher/... PS2, Line 164: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/bap/ode_e20XX... File src/mainboard/bap/ode_e20XX/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/bap/ode_e20XX... PS2, Line 108: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/bap/ode_e20XX... PS2, Line 168: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/biostar/a68n_... File src/mainboard/biostar/a68n_5200/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/biostar/a68n_... PS2, Line 104: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/biostar/a68n_... PS2, Line 164: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/gizmosphere/g... File src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c:
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/gizmosphere/g... PS2, Line 104: /* Enable IMC fan control, the recommanded way */ 'recommanded' may be misspelled - perhaps 'recommended'?
https://review.coreboot.org/c/coreboot/+/38609/2/src/mainboard/gizmosphere/g... PS2, Line 164: /* HWM fan control, the way not recommanded */ 'recommanded' may be misspelled - perhaps 'recommended'?
Hello Alexander Couzens, Patrick Rudolph, Peter Lemenkov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38609
to look at the new patch set (#3).
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos
Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c 7 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/38609/3
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38609/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38609/3//COMMIT_MSG@7 PS3, Line 7: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos mb: Fix typos in comments in AGESA boards
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38609/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38609/3//COMMIT_MSG@7 PS3, Line 7: mb/{amd,bap,biostar,gizmosphere,lenovo}: Fix typos
mb: Fix typos in comments in AGESA boards
Done
Hello Alexander Couzens, Patrick Rudolph, Peter Lemenkov, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38609
to look at the new patch set (#4).
Change subject: mb: Fix typos in comments in AGESA boards ......................................................................
mb: Fix typos in comments in AGESA boards
Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c 7 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/38609/4
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38609 )
Change subject: mb: Fix typos in comments in AGESA boards ......................................................................
mb: Fix typos in comments in AGESA boards
Change-Id: I4821c48ccac92f412126cea0f22cca5fd8bf8647 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/38609 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/amd/olivehill/BiosCallOuts.c M src/mainboard/amd/parmer/BiosCallOuts.c M src/mainboard/amd/thatcher/BiosCallOuts.c M src/mainboard/bap/ode_e20XX/BiosCallOuts.c M src/mainboard/biostar/a68n_5200/BiosCallOuts.c M src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c M src/mainboard/lenovo/g505s/BiosCallOuts.c 7 files changed, 61 insertions(+), 61 deletions(-)
Approvals: build bot (Jenkins): Verified Peter Lemenkov: Looks good to me, approved
diff --git a/src/mainboard/amd/olivehill/BiosCallOuts.c b/src/mainboard/amd/olivehill/BiosCallOuts.c index 4f780b3..6e29d84 100644 --- a/src/mainboard/amd/olivehill/BiosCallOuts.c +++ b/src/mainboard/amd/olivehill/BiosCallOuts.c @@ -95,13 +95,13 @@
/* Olivehill Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,12 +156,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/amd/parmer/BiosCallOuts.c b/src/mainboard/amd/parmer/BiosCallOuts.c index 59d6bf6..322b220 100644 --- a/src/mainboard/amd/parmer/BiosCallOuts.c +++ b/src/mainboard/amd/parmer/BiosCallOuts.c @@ -95,13 +95,13 @@
/* Parmer Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,12 +156,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/amd/thatcher/BiosCallOuts.c b/src/mainboard/amd/thatcher/BiosCallOuts.c index f8b7539..01dc5ab 100644 --- a/src/mainboard/amd/thatcher/BiosCallOuts.c +++ b/src/mainboard/amd/thatcher/BiosCallOuts.c @@ -93,15 +93,15 @@ #define FREQ_14HZ 0xFE #define FREQ_11HZ 0xFF
-/* Parmer Hardware Monitor Fan Control +/* Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,12 +156,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/bap/ode_e20XX/BiosCallOuts.c b/src/mainboard/bap/ode_e20XX/BiosCallOuts.c index 9ebef55..27d1dca 100644 --- a/src/mainboard/bap/ode_e20XX/BiosCallOuts.c +++ b/src/mainboard/bap/ode_e20XX/BiosCallOuts.c @@ -97,15 +97,15 @@ #define FREQ_14HZ 0xFE #define FREQ_11HZ 0xFF
-/* Hardware Monitor Fan Control +/* Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -160,12 +160,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c index 0caa718..fe4fab5 100644 --- a/src/mainboard/biostar/a68n_5200/BiosCallOuts.c +++ b/src/mainboard/biostar/a68n_5200/BiosCallOuts.c @@ -93,15 +93,15 @@ #define FREQ_14HZ 0xFE #define FREQ_11HZ 0xFF
-/* Olivehill Hardware Monitor Fan Control +/* Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,12 +156,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c b/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c index a3fbb25..8fa8ab5 100644 --- a/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c +++ b/src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c @@ -93,15 +93,15 @@ #define FREQ_14HZ 0xFE #define FREQ_11HZ 0xFF
-/* Hardware Monitor Fan Control +/* Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommand way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -156,12 +156,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwride it. - * so we remove it from AGESA code. Please Seee FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommand */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */ diff --git a/src/mainboard/lenovo/g505s/BiosCallOuts.c b/src/mainboard/lenovo/g505s/BiosCallOuts.c index 876b524..dfe53ea 100644 --- a/src/mainboard/lenovo/g505s/BiosCallOuts.c +++ b/src/mainboard/lenovo/g505s/BiosCallOuts.c @@ -92,15 +92,15 @@ #define FREQ_14HZ 0xFE #define FREQ_11HZ 0xFF
-/* Parmer Hardware Monitor Fan Control +/* Hardware Monitor Fan Control * Hardware limitation: - * HWM failed to read the input temperture vi I2C, - * if other software switch the I2C switch by mistake or intention. - * We recommend to using IMC to control Fans, instead of HWM. + * HWM failed to read the input temperature via I2C, + * if other software switches the I2C switch by mistake or intention. + * We recommend using IMC to control Fans, instead of HWM. */ static void oem_fan_control(FCH_DATA_BLOCK *FchParams) { - /* Enable IMC fan control. the recommend way */ + /* Enable IMC fan control, the recommended way */ if (CONFIG(HUDSON_IMC_FWM)) { imc_reg_init();
@@ -155,12 +155,12 @@ FchParams->Imc.EcStruct.IMCFUNSupportBitMap = 0x111;//BIT0 | BIT4 |BIT8;
/* NOTE: - * FchInitLateHwm will overwrite the EcStruct with EcDefaultMassege, - * AGESA put EcDefaultMassege as global data in ROM, so we can't overwrite it. - * so we remove it from AGESA code. Please See FchInitLateHwm. + * FchInitLateHwm will overwrite the EcStruct with EcDefaultMessage, + * AGESA puts EcDefaultMessage as global data in ROM, so we can't overwrite it. + * So we remove it from AGESA code. Please See FchInitLateHwm. */ } else { - /* HWM fan control, the way not recommend */ + /* HWM fan control, the way not recommended */ FchParams->Imc.ImcEnable = FALSE; FchParams->Hwm.HwMonitorEnable = TRUE; FchParams->Hwm.HwmFchtsiAutoPoll = TRUE;/* 1 enable, 0 disable TSI Auto Polling */
-
build bot (Jenkins) (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)