Attention is currently required from: Wisley Chen. Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/57753
to review the following change.
Change subject: mb/google/brya/var/redrix: Update audio setting ......................................................................
mb/google/brya/var/redrix: Update audio setting
Update codec/amp setting. 1. Update hid for ALC5682VS 2. Add maxim properties.
BUG=b:197076844 TEST=build and check SSDT
Change-Id: I8bedd4d0737caf46769ad27bce1768c225ce8a82 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/mainboard/google/brya/variants/redrix/overridetree.cb 1 file changed, 28 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/57753/1
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index ea922e0..735cb02 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -8,8 +8,8 @@ option KB_BL_PRESENT 1 end field AUDIO 3 5 - option AUDIO_UNKNOWN 0 - option MAX98390_ALC5682I_I2S 1 + option AUDIO_UNKNOWN 0 + option MAX98390_ALC5682I_I2S_4SPK 1 end field DB_LTE 6 7 option LTE_ABSENT 0 @@ -195,7 +195,7 @@ end #PCIE8 SD card device ref i2c0 on chip drivers/i2c/generic - register "hid" = ""10EC5682"" + register "hid" = ""RTL5682"" register "name" = ""RT58"" register "desc" = ""Headset Codec"" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A23)" @@ -205,6 +205,7 @@ register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" device i2c 1a on + probe AUDIO MAX98390_ALC5682I_I2S_4SPK end end chip drivers/i2c/max98390 @@ -213,7 +214,12 @@ register "name" = ""MXW0"" register "r0_calib_key" = ""dsm_calib_r0_0"" register "temperature_calib_key" = ""dsm_calib_temp_0"" - device i2c 0x3a on end + register "dsm_param_file_name" = ""dsm_param"" + register "vmon_slot_no" = "0" + register "imon_slot_no" = "1" + device i2c 0x3a on + probe AUDIO MAX98390_ALC5682I_I2S_4SPK + end end chip drivers/i2c/max98390 register "desc" = ""MAX98390 Speaker Amp 1"" @@ -221,7 +227,12 @@ register "name" = ""MXW1"" register "r0_calib_key" = ""dsm_calib_r0_1"" register "temperature_calib_key" = ""dsm_calib_temp_1"" - device i2c 0x3b on end + register "dsm_param_file_name" = ""dsm_param"" + register "vmon_slot_no" = "1" + register "imon_slot_no" = "0" + device i2c 0x3b on + probe AUDIO MAX98390_ALC5682I_I2S_4SPK + end end chip drivers/i2c/max98390 register "desc" = ""MAX98390 Speaker Amp 2"" @@ -229,7 +240,12 @@ register "name" = ""MXW2"" register "r0_calib_key" = ""dsm_calib_r0_2"" register "temperature_calib_key" = ""dsm_calib_temp_2"" - device i2c 0x38 on end + register "dsm_param_file_name" = ""dsm_param_tt"" + register "vmon_slot_no" = "2" + register "imon_slot_no" = "3" + device i2c 0x38 on + probe AUDIO MAX98390_ALC5682I_I2S_4SPK + end end chip drivers/i2c/max98390 register "desc" = ""MAX98390 Speaker Amp 3"" @@ -237,7 +253,12 @@ register "name" = ""MXW3"" register "r0_calib_key" = ""dsm_calib_r0_3"" register "temperature_calib_key" = ""dsm_calib_temp_3"" - device i2c 0x39 on end + register "dsm_param_file_name" = ""dsm_param_tt"" + register "vmon_slot_no" = "3" + register "imon_slot_no" = "2" + device i2c 0x39 on + probe AUDIO MAX98390_ALC5682I_I2S_4SPK + end end end #I2C0 device ref i2c1 on