Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Angel Pons (Code Review)]

Attention is currently required from: Arthur Heymans, Bill XIE, Nico Huber, Patrick Rudolph, Julius Werner, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 31:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/51671/comment/a3acc4a1_083f5512 
PS29, Line 22: Test passed on Elitebook Folio 9470m.
> EC_HP_KBC1126_ECFW_IN_CBFS is disabled in folio_9480m's Kconfig. […]

You're right, I confused the two. Apologies for the noise.

File src/arch/x86/Kconfig:

https://review.coreboot.org/c/coreboot/+/51671/comment/93bfbeb5_299ee9bf 
PS29, Line 357: config ECFW_PTR_SIZE
              : 	int
              : 	help
              : 	   Size of reserved space for EC firmware pointer
> Now it is used in ecfw_ptr.c as a static assert.

Hmmm, but arch/x86 still doesn't use it. I'd simply remove the Kconfig and use a literal `8` in ecfw_ptr.c

File src/ec/hp/kbc1126/ecfw_ptr.h:

https://review.coreboot.org/c/coreboot/+/51671/comment/35003430_8d2e35b2 
PS31, Line 8: struct ecfw_addr {
            : 	/* 8-byte offset of firmware blob in big endian */
            : 	uint16_t off;
            : 	/* bitwise inverse of "off", for error checking */
            : 	uint16_t inv;
            : };
            : 
            : struct ecfw_ptr {
            : 	struct ecfw_addr fw1;
            : 	struct ecfw_addr fw2;
            : };
These structs should be `__packed` to ensure the compiler doesn't add any padding.