Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Werner Zeh, Patrick Rudolph. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55082 )
Change subject: soc/intel/elkhartlake: Update FSP-S storage related configs ......................................................................
Patch Set 9:
(3 comments)
File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55082/comment/b9ace972_e42aacab PS8, Line 84: # LPSS Serial IO (I2C/UART/GSPI) related UPDs
I would expect this line being part of CB:54959
Ack. Unfortunately i just found the patch has been merged.
File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55082/comment/705210f4_64ab6b00 PS8, Line 20: DEF_DITOVAL
Would you mind to change it to DEF_DITOVAL_MS to clarify that this value is in ms units?
Done
https://review.coreboot.org/c/coreboot/+/55082/comment/967622f6_bcbec8e3 PS8, Line 253: params->SataPortsDmVal[i] = config->SataPortsDmVal[i] ? : config->SataPortsDmVal[i] : DEF_DMVAL;
Here you can shorten down the line as you are checking for a value which is assigned in the "true"-c […]
Good one! Done, thanks.