Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45920 )
Change subject: nb/intel/ironlake: Account for TSEG alignment ......................................................................
nb/intel/ironlake: Account for TSEG alignment
The TSEGMB register has 1 MiB granularity, but do not rely on reserved bits being zero. Raminit aligns TSEG to a 8 MiB boundary, anyway.
Change-Id: Iedb63f7c7a29172da187030e33197fc6e4ee23f8 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/ironlake/memmap.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/45920/1
diff --git a/src/northbridge/intel/ironlake/memmap.c b/src/northbridge/intel/ironlake/memmap.c index 78fbae8..221ae92 100644 --- a/src/northbridge/intel/ironlake/memmap.c +++ b/src/northbridge/intel/ironlake/memmap.c @@ -14,7 +14,7 @@ static uintptr_t northbridge_get_tseg_base(void) { /* Base of TSEG is top of usable DRAM */ - return pci_read_config32(PCI_DEV(0, 0, 0), TSEG); + return ALIGN_DOWN(pci_read_config32(PCI_DEV(0, 0, 0), TSEG), 1 * MiB); }
static size_t northbridge_get_tseg_size(void)
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45920?usp=email )
Change subject: nb/intel/ironlake: Account for TSEG alignment ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.