Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23027 )
Change subject: mb/solidrun/solidpc: Do initial commit
......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol...
File src/mainboard/solidrun/solidpc/Kconfig:
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol...
PS12, Line 6: ENABLE_BUILTIN_COM1
This is actually built-in serial port in the LPC, present on braswell and used on this board. […]
I agree, this symbol should be more like HAVE_ACPI_RESUME, in the sense that it indicates a capability of the board.
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol...
PS12, Line 21:
: config MAINBOARD_VENDOR
: string
: default "SolidRun"
Should be set from src/mainboard/solidrun/Kconfig
https://review.coreboot.org/c/coreboot/+/23027/12/src/mainboard/solidrun/sol...
PS12, Line 28: 126
128?
The checksums are missing from the spd files, which explains the two missing bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/23027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00ff95313d74091e7411f6c8658d0d560a0e682b
Gerrit-Change-Number: 23027
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Mon, 09 Dec 2019 18:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment