Change in coreboot[master]: mb/google/corsola: Add NOR-Flash support - coreboot-gerrit

4 Nov 2021


      Attention is currently required from: Hung-Te Lin, Felix Held.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58838 )
Change subject: mb/google/corsola: Add NOR-Flash support
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/corsola/bootblock.c:
PS3:
...
some of the gpio struct definitions and handling code in here looks to me that it should probably be […]
There is two sets of GPIO for SPINOR on 8186.
It is determined by how boards use these GPIOs.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58838
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee3dd336632b0cf998f5f7c1d118e01e8270e815
Gerrit-Change-Number: 58838
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Nov 2021 02:49:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment