Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86013?usp=email )
Change subject: soc/mediatek/mt8196: Add mtk-fsp loader in ramstage ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86013/comment/b84b7af1_0b04918e?usp... : PS1, Line 9: include includes
https://review.coreboot.org/c/coreboot/+/86013/comment/3b797f4a_b48053e8?usp... : PS1, Line 15:
Add support for running the ramstage blob mtk_fsp_ramstage. […]
No longer needed since the implementation uses a static buffer.
File src/soc/mediatek/common/include/soc/memlayout.h:
https://review.coreboot.org/c/coreboot/+/86013/comment/c9212e67_24e7efc9?usp... : PS1, Line 24: #define FSP_INIT_CODE(addr, size) \
Move below `DRAM_INIT_CODE`.
Just remove
File src/soc/mediatek/mt8196/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/86013/comment/8c368502_6b0eaf91?usp... : PS1, Line 67: FSP_INIT_CODE(0x90000000, 2M) not needed
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/86013/comment/8571e034_448d4442?usp... : PS1, Line 40: sizeof(ufs_storage_type), &ufs_storage_type); move to above line