Change in coreboot[master]: mb/google/brya/var/*: Add disable_gpio_export_in_crs to all devicetrees

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60175 )

Change subject: mb/google/brya/var/*: Add disable_gpio_export_in_crs to all devicetrees
......................................................................

mb/google/brya/var/*: Add disable_gpio_export_in_crs to all devicetrees

None of the touchscreens used in the brya program (any brya board)
should require exporting of GPIOs in the ACPI _CRS method for any i2c
device. This can cause i2c devices to malfunction or cause timing
sequence violations if:

1) ACPI exports a PowerResource for the device that uses GPIOs that are
   also exported in _CRS
2) The kernel driver for the device uses the GPIOs exported in _CRS for
   its own purposes. This means the state of the pin is out of sync
   between platform firmware and the kernel. The Linux ELAN I2C
   touchcsreen driver (https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...)
   is one example of this.

Therefore, add disable_gpio_export_in_crs to all brya variants that use
the drivers/i2c/generic or drivers/i2c/hid chip drivers.

Change-Id: Ib4475bd0dc885e230911de6298fd95baa868ef29
Signed-off-by: Tim Wawrzynczak 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60175
Tested-by: build bot (Jenkins) 
Reviewed-by: Raul Rangel 
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/primus4es/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
13 files changed, 20 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Raul Rangel: Looks good to me, approved

diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb
index dc563a4..118ce0c 100644
--- a/src/mainboard/google/brya/variants/anahera/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb
@@ -215,6 +215,7 @@
    			register "stop_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
    			device i2c 10 on end
    		end
    		chip drivers/i2c/hid
@@ -229,6 +230,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 40 on end
    		end
diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
index dc563a4..118ce0c 100644
--- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
@@ -215,6 +215,7 @@
    			register "stop_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
    			device i2c 10 on end
    		end
    		chip drivers/i2c/hid
@@ -229,6 +230,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 40 on end
    		end
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index c2da329..f9301fe 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -260,6 +260,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 10 on end
    		end
diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 4bfe124..3d8f52b 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -217,6 +217,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x15 on end
    		end
diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
index 5d6d4fc..d0d54d7 100644
--- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
@@ -173,6 +173,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x15 on end
    		end
diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb
index a908a7b..a4a5c54 100644
--- a/src/mainboard/google/brya/variants/kano/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kano/overridetree.cb
@@ -425,6 +425,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x10 on end
    		end
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb
index 64d0a8f..0ddf2b1 100644
--- a/src/mainboard/google/brya/variants/primus/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus/overridetree.cb
@@ -236,6 +236,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x10 on end
    		end
@@ -251,6 +252,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x40 on end
    		end
diff --git a/src/mainboard/google/brya/variants/primus4es/overridetree.cb b/src/mainboard/google/brya/variants/primus4es/overridetree.cb
index ce6bec5..fffc1d0 100644
--- a/src/mainboard/google/brya/variants/primus4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus4es/overridetree.cb
@@ -223,6 +223,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x10 on end
    		end
@@ -238,6 +239,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x40 on end
    		end
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index 617ebc5..5aa84bdc 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -386,6 +386,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x15 on end
    		end
diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
index 9531e5e..9ffc6a0 100644
--- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
@@ -270,6 +270,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 0x15 on end
    		end
diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb
index ff4feef..985745f 100644
--- a/src/mainboard/google/brya/variants/taeko/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb
@@ -292,6 +292,7 @@
    			# Parameter T4 >= 1ms
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 5d on end
    		end
@@ -307,6 +308,7 @@
    					"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "enable_delay_ms" = "1"
    			register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
    			device i2c 10 on end
    		end
    	end
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
index d485662..dbca8ee 100644
--- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
@@ -292,6 +292,7 @@
    			# Parameter T4 >= 1ms
    			register "generic.stop_off_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 5d on end
    		end
@@ -307,6 +308,7 @@
    					"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "enable_delay_ms" = "1"
    			register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
    			device i2c 10 on end
    		end
    	end
diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb
index a65c859..483dce7 100644
--- a/src/mainboard/google/brya/variants/vell/overridetree.cb
+++ b/src/mainboard/google/brya/variants/vell/overridetree.cb
@@ -191,6 +191,7 @@
    			register "stop_gpio" =
    						"ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
    			register "has_power_resource" = "1"
+				register "disable_gpio_export_in_crs" = "1"
    			device i2c 10 on end
    		end
    		chip drivers/i2c/hid
@@ -205,6 +206,7 @@
    						"ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
    			register "generic.enable_delay_ms" = "1"
    			register "generic.has_power_resource" = "1"
+				register "generic.disable_gpio_export_in_crs" = "1"
    			register "hid_desc_reg_offset" = "0x01"
    			device i2c 40 on end
    		end