Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56043 )
Change subject: intel/harcuvar/Kconfig: Clean up unused code ......................................................................
intel/harcuvar/Kconfig: Clean up unused code
This was only used in the sample and it's just a bad way of doing things. One should use a leaked mmaped address to the spd bin instead of hardcoding it.
Change-Id: I7f243d8ef4682bfc51fb6ba5af939308a875a0d1 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/intel/harcuvar/Kconfig M src/mainboard/intel/harcuvar/romstage.c M src/mainboard/intel/harcuvar/spd/Makefile.inc 3 files changed, 1 insertion(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/56043/1
diff --git a/src/mainboard/intel/harcuvar/Kconfig b/src/mainboard/intel/harcuvar/Kconfig index 05a8d2d..fd4b6ad050 100644 --- a/src/mainboard/intel/harcuvar/Kconfig +++ b/src/mainboard/intel/harcuvar/Kconfig @@ -23,11 +23,4 @@ help Select this option to enable Memory Down function.
-config SPD_LOC - depends on ENABLE_FSP_MEMORY_DOWN - hex "SPD binary location in cbfs" - default 0xfffdf000 - help - Location of SPD binary for memory down function. - endif # BOARD_INTEL_HARCUVAR diff --git a/src/mainboard/intel/harcuvar/romstage.c b/src/mainboard/intel/harcuvar/romstage.c index 027c56e..1f502be 100644 --- a/src/mainboard/intel/harcuvar/romstage.c +++ b/src/mainboard/intel/harcuvar/romstage.c @@ -33,22 +33,9 @@ * DIMM Mapping of SlotState & SpdDataPtr: * * {{CH0DIMM0, CH0DIMM1}, {CH1DIMM0, CH1DIMM1}} - * - * Sample: Channel 0 is memory down and channel 1 is physical slot. - * - * const MEMORY_DOWN_CONFIG mMemoryDownConfig = { - * .SlotState = { - * {STATE_MEMORY_DOWN, STATE_MEMORY_DOWN}, - * {STATE_MEMORY_SLOT, STATE_MEMORY_SLOT} - * }, - * .SpdDataLen = MAX_SPD_BYTES, - * .SpdDataPtr = { - * {(void *)CONFIG_SPD_LOC, (void *)CONFIG_SPD_LOC}, - * {(void *)NULL, (void *)NULL} - * } - * } */
+ const MEMORY_DOWN_CONFIG mMemoryDownConfig = { .SlotState = { {STATE_MEMORY_SLOT, STATE_MEMORY_SLOT}, diff --git a/src/mainboard/intel/harcuvar/spd/Makefile.inc b/src/mainboard/intel/harcuvar/spd/Makefile.inc index ec07cfb..57b8e9b 100644 --- a/src/mainboard/intel/harcuvar/spd/Makefile.inc +++ b/src/mainboard/intel/harcuvar/spd/Makefile.inc @@ -5,5 +5,3 @@ # Order matters for SPD sources. The following indices # define the SPD data to use. SPD_SOURCES = micron_4GiB_dimm_MTA9ASF51272PZ-2G1A2 - -spd.bin-position := $(CONFIG_SPD_LOC)