Attention is currently required from: Tarun Tuli, Eran Mitrani.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68821 )
Change subject: mb/google/hatch: Add variant finalize support for hatch devices
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File src/mainboard/google/hatch/ramstage.c:
https://review.coreboot.org/c/coreboot/+/68821/comment/73726b10_6e03ed4b
PS14, Line 58: void __weak variant_final(void)
This wouldn't only be for GPIO. We could in theory do whatever finalize work we want to in here. […]
Good point on the only for GPIO. I think this is fine here given that's why the weak declaration for variant_finalize_gpio_table() was put into gpio.c instead of here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9253ed4be1b08d0c7f65526c9b26dbcd00ffccc7
Gerrit-Change-Number: 68821
Gerrit-PatchSet: 14
Gerrit-Owner: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 20:36:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tarun Tuli
taruntuli@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment