build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/15164 )
Change subject: nb/amd/pi/00730F01: Add initial native IVRS support ......................................................................
Patch Set 19:
(12 comments)
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 459: if ((dev->bus->secondary == 0x0) && (dev->path.pci.devfn == 0x0)) line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 506: is_pcie = pci_find_capability(dev, PCI_CAP_ID_PCIE); line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 527: } else if ((header_type == PCI_HEADER_TYPE_NORMAL) && line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 527: } else if ((header_type == PCI_HEADER_TYPE_NORMAL) && that open brace { should be on the previous line
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 556: for (sibling = link->children; sibling; sibling = sibling->sibling) line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 557: add_ivrs_device_entries(dev, sibling, depth + 1, depth, root_level, current, length); line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 562: unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t* ivrs, unsigned long current) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 599: static unsigned long acpi_fill_ivrs(acpi_ivrs_t* ivrs, unsigned long current) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 605: printk(BIOS_WARNING, "acpi_fill_ivrs: Unable to locate G-series northbridge device! IVRS table not generated...\n"); Prefer using '"%s...", __func__' to using 'acpi_fill_ivrs', this function's name, in a string
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 619: ivrs->ivhd.flags |= 0x10; /* Enable ATS support */ line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 621: ivrs->ivhd.device_id = 0x2 | (nb_dev->bus->secondary << 8); /* BDF <bus>:00.2 */ line over 80 characters
https://review.coreboot.org/#/c/15164/19/src/northbridge/amd/pi/00730F01/nor... PS19, Line 622: ivrs->ivhd.capability_offset = 0x40; /* Capability block 0x40 (type 0xf, "Secure device") */ line over 80 characters
-
build bot (Jenkins) (Code Review)