Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79856?usp=email )
(
2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/nvidia: Put static keyword at the beginning of declarations ......................................................................
soc/nvidia: Put static keyword at the beginning of declarations
In order to comply with the more recent style of declarations, put the static keyword at the beginning.
Fixes following GCC error when the related flag is set:
error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
Change-Id: Ida683319f7a0c428a9e4808821075abdd9fcb504 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/79856 Reviewed-by: Julius Werner jwerner@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra210/clock.c 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/soc/nvidia/tegra124/clock.c b/src/soc/nvidia/tegra124/clock.c index f8a232f..0dae02d 100644 --- a/src/soc/nvidia/tegra124/clock.c +++ b/src/soc/nvidia/tegra124/clock.c @@ -80,7 +80,7 @@ * PLLU: 1 MHz < CF < 6 MHz, 480 MHz < VCO < 960 MHz * PLLDP: 12 MHz < CF < 38 MHz, 600 MHz < VCO < 1200 MHz * (values taken from Linux' drivers/clk/tegra/clk-tegra124.c). */ -struct { +static const struct { int khz; struct pllcx_dividers pllx; /* target: CONFIG_PLLX_KHZ */ struct pllcx_dividers pllc; /* target: 600 MHz */ @@ -89,7 +89,7 @@ struct pllu_dividers pllu; /* target; 960 MHz */ struct pllcx_dividers plldp; /* target; 270 MHz */ /* PLLDP treats p differently (OUT = VCO / (p + 1) for p < 6). */ -} static const osc_table[16] = { +} osc_table[16] = { [OSC_FREQ_12] = { .khz = 12000, .pllx = {.n = TEGRA_PLLX_KHZ / 12000, .m = 1, .p = 0}, diff --git a/src/soc/nvidia/tegra210/clock.c b/src/soc/nvidia/tegra210/clock.c index 95507e3..4433d7e 100644 --- a/src/soc/nvidia/tegra210/clock.c +++ b/src/soc/nvidia/tegra210/clock.c @@ -27,7 +27,7 @@ PLL_MAX_INDEX, };
-struct pll_reg_info { +static const struct pll_reg_info { u32 *base_reg; u32 *lock_enb_reg; u32 lock_enb_val; @@ -40,7 +40,7 @@ u32 kcp_shift:5; /* kcp bits location */ u32 kvco_shift:5; /* kvco bit location */ u32 rsvd:7; -} static const pll_reg_table[] = { +} pll_reg_table[] = { [PLLX_INDEX] = { .base_reg = CLK_RST_REG(pllx_base), .lock_enb_reg = CLK_RST_REG(pllx_misc), .lock_enb_val = PLLPAXS_MISC_LOCK_ENABLE, @@ -127,10 +127,10 @@ * PLLM is set up dynamically by clock_sdram(). * PLLP is hardwired to 408 MHz in HW (unless we set BASE_OVRD). */ -struct { +static struct { int khz; struct pll_fields plls[PLL_MAX_INDEX]; -} static osc_table[16] = { +} osc_table[16] = { [OSC_FREQ_12] = { .khz = 12000, .plls = {