Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36444 )
Change subject: device/Kconfig: hide display menu when NO_GFX_INIT is selected
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36444/1/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/36444/1/src/device/Kconfig@a255
PS1, Line 255: depends on HAVE_VGA_TEXT_FRAMEBUFFER || HAVE_LINEAR_FRAMEBUFFER
These should already imply !NO_GFX_INIT. I guess you could move the
dependency there so nobody can select them by accident?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36444
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec5a47f84b8c776a45edc6f4b31a03b9ac714b4e
Gerrit-Change-Number: 36444
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 22:45:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment