Attention is currently required from: Shelley Chen, Ravi kumar, Paul Menzel, mturney mturney, Julius Werner. Taniya Das has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 )
Change subject: qualcomm/sc7180: Clean up drivers with common clock ......................................................................
Patch Set 7:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56587/comment/d06dd232_c95b7f39 PS5, Line 7: Cleanups for drivers with common clock
Clean up drivers with common clock
Done
Patchset:
PS7:
Can you please fix the last couple of small things? Thanks!
Done.
File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/56587/comment/8c6edc37_379abf5b PS5, Line 131: int
When using the CB_xxx error values, please use the return type `enum cb_err` instead of a standard i […]
Done
https://review.coreboot.org/c/coreboot/+/56587/comment/79cfc9b5_91727140 PS5, Line 172: while
This should be an `if` now
Done
https://review.coreboot.org/c/coreboot/+/56587/comment/596a41e0_4479276b PS5, Line 183: while
same
Done
https://review.coreboot.org/c/coreboot/+/56587/comment/b70eda21_95da4262 PS5, Line 311: if (ret < 0)
If you want to use the cb_err type, use it consistently (i.e. […]
Done
https://review.coreboot.org/c/coreboot/+/56587/comment/a3265a36_4778aeb6 PS5, Line 356: divider
nit: Would be easier to just say `divider * 2 - 1` here?
File src/soc/qualcomm/sc7180/watchdog.c:
https://review.coreboot.org/c/coreboot/+/56587/comment/d1273fa8_67244462 PS5, Line 8: #define WDOG_RESET_BIT_MASK 1
If you add this here you also should remove it from clock.h in this same patch.
Done
-
Taniya Das (Code Review)