Attention is currently required from: Kapil Porwal, Himanshu Sahdev.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765 )
Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload ......................................................................
Patch Set 4:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74765/comment/15439d07_6e0aa61d PS4, Line 9: might require more time : to process the EOP command Please document your measured numbers.
https://review.coreboot.org/c/coreboot/+/74765/comment/420d2ada_53b7c22b PS4, Line 10: Currently any boot time improvement in : coreboot leads to increase in EOP processing time I do not fully understand this. The EOP processing is happening in parallel and should be constant?
https://review.coreboot.org/c/coreboot/+/74765/comment/7eeeba93_6abdbab9 PS4, Line 14: This improves boot time by ~10ms milliseconds. Can the CSE firmware be updated to boot faster?
https://review.coreboot.org/c/coreboot/+/74765/comment/518478df_432bf1c1 PS4, Line 17: TEST=Verify sending EOP from depthcharge On what devices?
File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/74765/comment/450ab5b4_c2b07734 PS4, Line 119: It has been observed that CSE might be busy and might require more time to Please add a blank line above, so paragraphs are visually separated.