Change in coreboot[master]: mb/bap/ode_e21XX: Drop old commented Kconfigs

List overview All Threads
Download

newer

older

Change in coreboot[master]: util:...

Change in coreboot[master]:...

Kyösti Mälkki (Code Review)

1 Jun 2020 1 Jun '20

12:34 p.m.

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

mb/bap/ode_e21XX: Drop old commented Kconfigs

Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/bap/ode_e21XX/Kconfig 1 file changed, 0 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/41966/1

diff --git a/src/mainboard/bap/ode_e21XX/Kconfig b/src/mainboard/bap/ode_e21XX/Kconfig index a454e8a..4d77280 100644 --- a/src/mainboard/bap/ode_e21XX/Kconfig +++ b/src/mainboard/bap/ode_e21XX/Kconfig @@ -7,8 +7,6 @@

config BOARD_SPECIFIC_OPTIONS def_bool y - #select BINARYPI_LEGACY_WRAPPER - #select ROMCC_BOOTBLOCK select CPU_AMD_PI_00730F01 select NORTHBRIDGE_AMD_PI_00730F01 select SOUTHBRIDGE_AMD_PI_AVALON

Attachments:

attachment.htm (text/html — 2.4 KB)

Show replies by date

Nico Huber (Code Review)

1 Jun 1 Jun

4:05 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 01 Jun 2020 14:05:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3 Jun 3 Jun

2:16 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

mb/bap/ode_e21XX: Drop old commented Kconfigs

Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41966 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/bap/ode_e21XX/Kconfig 1 file changed, 0 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

config BOARD_SPECIFIC_OPTIONS def_bool y - #select BINARYPI_LEGACY_WRAPPER - #select ROMCC_BOOTBLOCK select CPU_AMD_PI_00730F01 select NORTHBRIDGE_AMD_PI_00730F01 select SOUTHBRIDGE_AMD_PI_AVALON

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

HAOUAS Elyes (Code Review)

9:18 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

Patch Set 2:

This board is disabled

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 03 Jun 2020 19:18:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

4 Jun 4 Jun

3:21 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

Patch Set 2:

...

Patch Set 2:

This board is disabled

Ah. Any reason why it was left out from same treatment like CB:39068, removal that is.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jun 2020 01:21:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

9:37 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

Patch Set 2:

...

Patch Set 2:

...
Patch Set 2:

This board is disabled

Ah. Any reason why it was left out from same treatment like CB:39068, removal that is.

I mean, we probably have to avoid touching the code as Jenkins will not check it. (here only commented lines where removed, so it's fine)

if I'm not wrong, you want to port this board. do you think you'll have time for this board?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jun 2020 07:37:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

9:58 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41966 )

Change subject: mb/bap/ode_e21XX: Drop old commented Kconfigs ......................................................................

Patch Set 2:

...

Patch Set 2:

...
Patch Set 2:

...
Patch Set 2:

This board is disabled

Ah. Any reason why it was left out from same treatment like CB:39068, removal that is.

I mean, we probably have to avoid touching the code as Jenkins will not check it. (here only commented lines where removed, so it's fine)

if I'm not wrong, you want to port this board. do you think you'll have time for this board?

I never had plans for this board. Like with rest of ROMCC_BOOTBLOCK my request was to only keep in those that see boot-testing. But other people wanted to do some boards blindfolded.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41966 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56225c0a533e5f9e8294b7866a41c9a6c24a7f67 Gerrit-Change-Number: 41966 Gerrit-PatchSet: 2 Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jun 2020 07:58:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1633

days inactive

1636

days old

coreboot-gerrit@coreboot.org

6 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)