Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75882?usp=email )
Change subject: mb/google/dedede/var/cret: Generate new SPD ID for new memory parts ......................................................................
mb/google/dedede/var/cret: Generate new SPD ID for new memory parts
Add new memory parts in the mem_parts_used.txt and generate the SPD ID for the parts. The memory parts being added are: 1. H54G56CYRBX247 2. H9HCNNNCPMMLXR-NEE 3. MT53E1G32D2NP-046 WT:B 4. K4UBE3D4AB-MGCL 5. K4UBE3D4AA-MGCR
BUG=b:290811418 BRANCH=dedede TEST=FW_NAME=cret emerge-dedede coreboot chromeos-bootimage
Change-Id: Ib7f23dc3604fe1869772d92c9d7b8cc32ed9bbb9 Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75882 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ian Feng ian_feng@compal.corp-partner.google.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/cret/memory/Makefile.inc M src/mainboard/google/dedede/variants/cret/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/cret/memory/mem_parts_used.txt 3 files changed, 11 insertions(+), 0 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Ian Feng: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/cret/memory/Makefile.inc b/src/mainboard/google/dedede/variants/cret/memory/Makefile.inc index 5bd1974..5c34b5f 100644 --- a/src/mainboard/google/dedede/variants/cret/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/cret/memory/Makefile.inc @@ -5,3 +5,4 @@
SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:F, K4U6E3S4AA-MGCR, MT53E512M32D1NP-046 WT:B, K4U6E3S4AB-MGCL, H54G46CYRBX267 +SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 1(0b0001) Parts = H54G56CYRBX247, H9HCNNNCPMMLXR-NEE, MT53E1G32D2NP-046 WT:B, K4UBE3D4AB-MGCL, K4UBE3D4AA-MGCR diff --git a/src/mainboard/google/dedede/variants/cret/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/cret/memory/dram_id.generated.txt index fc789d3..15cf90a 100644 --- a/src/mainboard/google/dedede/variants/cret/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/cret/memory/dram_id.generated.txt @@ -10,3 +10,8 @@ MT53E512M32D1NP-046 WT:B 0 (0000) K4U6E3S4AB-MGCL 0 (0000) H54G46CYRBX267 0 (0000) +H54G56CYRBX247 1 (0001) +H9HCNNNCPMMLXR-NEE 1 (0001) +MT53E1G32D2NP-046 WT:B 1 (0001) +K4UBE3D4AB-MGCL 1 (0001) +K4UBE3D4AA-MGCR 1 (0001) diff --git a/src/mainboard/google/dedede/variants/cret/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/cret/memory/mem_parts_used.txt index d163884..6ba53d7 100644 --- a/src/mainboard/google/dedede/variants/cret/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/cret/memory/mem_parts_used.txt @@ -4,3 +4,8 @@ MT53E512M32D1NP-046 WT:B K4U6E3S4AB-MGCL H54G46CYRBX267 +H54G56CYRBX247 +H9HCNNNCPMMLXR-NEE +MT53E1G32D2NP-046 WT:B +K4UBE3D4AB-MGCL +K4UBE3D4AA-MGCR