Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Update to use upstream version 4.3.10
Upstream 4.3.10 is using a different download slot, adjusting the makechips.sh script.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I740885e4773dcbd236d1a645e03b6896bf39c0d1 --- M makechips.sh 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/37/45537/1
diff --git a/makechips.sh b/makechips.sh index fcf0070..8a2d901 100755 --- a/makechips.sh +++ b/makechips.sh @@ -12,7 +12,7 @@ # GNU General Public License for more details. #
-URL="https://www.dediprog.com/download/save/78.msi" +URL="https://www.dediprog.com/download/save/1145.msi" VURL="https://www.dediprog.com/download?productCategory=SPI+Flash+Solution&pro..."
if ! which curl > /dev/null; then
Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG@7 PS1, Line 7: Update to use upstream version 4.3.10 “Update to use” is redundant.
Update to upstream version 4.3.10
Use upstream version 4.3.10
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG@9 PS1, Line 9: adjusting adjust
Hello build bot (Jenkins), Ryan O'Leary,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/45537
to look at the new patch set (#2).
Change subject: Update to use upstream version 4.3.10 ......................................................................
Update to use upstream version 4.3.10
Upstream 4.3.10 is using a different download slot, adjust the makechips.sh script.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I740885e4773dcbd236d1a645e03b6896bf39c0d1 --- M makechips.sh 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/37/45537/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG@7 PS1, Line 7: Update to use upstream version 4.3.10
“Update to use” is redundant. […]
Done
https://review.coreboot.org/c/em100/+/45537/1//COMMIT_MSG@9 PS1, Line 9: adjusting
adjust
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Patch Set 2: Code-Review+2
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/45537 )
Change subject: Update to use upstream version 4.3.10 ......................................................................
Update to use upstream version 4.3.10
Upstream 4.3.10 is using a different download slot, adjust the makechips.sh script.
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I740885e4773dcbd236d1a645e03b6896bf39c0d1 Reviewed-on: https://review.coreboot.org/c/em100/+/45537 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Ryan O'Leary ryanoleary@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M makechips.sh 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Ryan O'Leary: Looks good to me, approved
diff --git a/makechips.sh b/makechips.sh index fcf0070..8a2d901 100755 --- a/makechips.sh +++ b/makechips.sh @@ -12,7 +12,7 @@ # GNU General Public License for more details. #
-URL="https://www.dediprog.com/download/save/78.msi" +URL="https://www.dediprog.com/download/save/1145.msi" VURL="https://www.dediprog.com/download?productCategory=SPI+Flash+Solution&pro..."
if ! which curl > /dev/null; then
-
Angel Pons (Code Review) -
Paul Menzel (Code Review)
-
Ryan O'Leary (Code Review)
-
Stefan Reinauer (Code Review)