Attention is currently required from: Andrey Petrov, Krishna P Bhat D, Ronak Kanabar, Varun Upadhyay.
Subrata Banik has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83055?usp=email )
Change subject: driver/intel/fsp2_0: Prevent error logs during S3 wakeup
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/intel/fsp2_0/fsp_gop_blt.c:
https://review.coreboot.org/c/coreboot/+/83055/comment/c64503b4_26f2c1a6?usp... :
PS2, Line 245: /* CBMEM is locked for S3 resume path. */
: if (acpi_is_wakeup_s3())
: return;
The current implementation returns NULL from bmp_load_logo() when the system is waking up from an S3 sleep state so it doesnt goes to draw FW Splash screen, This change is just eliminating error messages that were being logged during the S3 resume process.
my point is shouldn't we draw FW splash screen during S3 resume ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83055?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I13463b5409e248cf4843c9a887a47d73459972a3
Gerrit-Change-Number: 83055
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Thu, 13 Jun 2024 08:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Varun Upadhyay
varun.upadhyay@intel.com